Remove dead comments#414
Conversation
Shimuuar
commented
Sep 8, 2021
Shimuuar
commented
- Type class is defined in D.V.Generic.Base. No reason to keep its commented out code
- Remove obsolete comment. When offending function (Data.Vector.Unboxed.unstream . Bundle.fromList) is compiled it produces rather straightforward core. It seems GHC fixed problem whatever it was.
- Typo in error message
No reason to keep its commented out code
When offending function (Data.Vector.Unboxed.unstream . Bundle.fromList) is compiled it produces rather straightforward core. It seems GHC fixed problem whatever it was.
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
I wanted to remove that stuff for the longest time, but kept forgetting about. Thank you for finally getting rid of it.
Some weird issue on CI, might be borked cache. I restarted it, maybe it will fix itself
It didn't. GHC 8.6.5 fails quite reliably on ubuntu with |
|
This is weird:
|
I'm not sure it's ghcup. But I guess it is. PPA does not for work for windows/mac and we don't treat them specially. I'll try to work around cache(?) problem |
CI jobs fail with weird error: > vector-doctest: /usr/local/.ghcup/ghc/8.6.5/bin/ghc-8.6.5: > getPermissions:getFileStatus: does not exist (No such file or directory) Let try to change cache key in order to avoid using possibly broken cache
|
I get a feeling this recent change might have something to do with it: https://github.com/actions/virtual-environments/pull/4016/files |
|
Maybe. Looks like dropping cache did the trick |
Remove dead comments and add versioning key to caching on CI: * Type class is defined in D.V.Generic.Base No reason to keep its commented out code * Fix error message * Remove obsolete comment When offending function (Data.Vector.Unboxed.unstream . Bundle.fromList) is compiled it produces rather straightforward core. It seems GHC fixed problem whatever it was. * There's another dead comment * Change key for GA cache CI jobs fail with weird error: > vector-doctest: /usr/local/.ghcup/ghc/8.6.5/bin/ghc-8.6.5: > getPermissions:getFileStatus: does not exist (No such file or directory) Let try to change cache key in order to avoid using possibly broken cache
2 participants
